[author] Extract out legacy usage of author annotations in favor of adding to pom #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding to pom git stores the history, leaving names ends up in humans blaming sections of code on whom is listed there. Better to give this in the pom so it further gives higher visibility of those that have contributed and wanted their names listed at one point or another.
mathieucarbou
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git stores the history, leaving names ends up in humans blaming sections of code on whom is listed there. Better to give this in the pom so it further gives higher visibility of those that have contributed and wanted their names listed at one point or another.
This further was causing issues with javadocs as the javadocs on many of these were entirely wrong in that they only had author listed and no context so the javadoc plugin is loud on issues. Newer maven versions further make warnings far more visible making it important to adjust.
Additionally not all files actually used author this way at all. So this gets us consistent. I didn't have the data to fill in everything in general but did what I could. Some users just had a name so I added it that way. I think many are already longer term contributors of the repo so the pom.xml could be bridged out further to better show where everyone can be tracked down more easily.