[java] Minor code cleanup

license-maven-plugin-fs/src/main/java/com/mycila/maven/plugin/license/fs/CopyrightRangeProvider.java

@@ -80,7 +80,7 @@ public Map<String, String> adjustProperties(AbstractLicenseMojo mojo,
       result.put(COPYRIGHT_YEARS_KEY, copyrightYears);
 
       return Collections.unmodifiableMap(result);
-    } catch (Throwable e) {
+    } catch (Exception e) {
       throw new RuntimeException(
           "CopyrightRangeProvider error on file: " + document.getFile().getAbsolutePath() + ": "
               + e.getMessage(), e);

license-maven-plugin-fs/src/test/java/com/mycila/maven/plugin/license/fs/CopyrightRangeProviderTest.java

@@ -24,15 +24,13 @@
 
 import java.io.File;
 import java.io.IOException;
-import java.net.URL;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.nio.file.attribute.FileTime;
 import java.time.Instant;
 import java.util.HashMap;
 import java.util.Map;
-import java.util.concurrent.TimeUnit;
 
 class CopyrightRangeProviderTest {
   private static Path fsRepoRoot;

license-maven-plugin-git/src/test/java/com/mycila/maven/plugin/license/git/CopyrightAuthorProviderTest.java

@@ -64,11 +64,6 @@ void copyrightAuthor() {
     }
   }
 
-  private void assertAuthor(CopyrightAuthorProvider provider, String path,
-                            String copyrightAuthorName, String copyrightAuthorEmail) {
-
-  }
-
   private static Document newDocument(String relativePath) {
     Path path = Paths.get(gitRepoRoot + File.separator
         + relativePath.replace('/', File.separatorChar));

license-maven-plugin-git/src/test/java/com/mycila/maven/plugin/license/git/GitLookupTest.java

@@ -204,13 +204,13 @@ private GitLookup newCommitterLookup() {
   }
 
   @Test
-  public void ignoreCommitsInLastChange() throws GitAPIException, IOException {
+  void ignoreCommitsInLastChange() throws GitAPIException, IOException {
     assertLastChange(newAuthorLookup("95d52919cbe340dc271cf1f5ec68cf36705bd3a3"), "dir1/file1.txt", 2004);
     assertLastChange(newCommitterLookup("95d52919cbe340dc271cf1f5ec68cf36705bd3a3"), "dir1/file1.txt", 2004);
   }
 
   @Test
-  public void doNotIgnoreCommitsInCreation() throws GitAPIException, IOException {
+  void doNotIgnoreCommitsInCreation() throws GitAPIException, IOException {
     assertCreation(newAuthorLookup("53b44baedc5a378f9b665da12f298e1003793219"), "dir1/file1.txt", 2000);
     assertCreation(newCommitterLookup("53b44baedc5a378f9b665da12f298e1003793219"), "dir1/file1.txt", 2000);
   }

license-maven-plugin-svn/src/main/java/com/mycila/maven/plugin/license/svn/SVNPropertiesProvider.java

@@ -127,20 +127,17 @@ public void handleLogEntry(SVNLogEntry logEntry) throws SVNException {
       // One-time warning for shallow repo
       if (mojo.warnIfShallow && !warnedIfShallow.get()) {
         SVNInfo info = svnClientManager.getWCClient().doInfo(documentFile, SVNRevision.HEAD);
-        if (info.getDepth() != SVNDepth.INFINITY) {
-          if (warnedIfShallow.compareAndSet(false, true)) {
-            mojo.warn(
-                "Sparse svn repository detected. Year property values may not be accurate.");
-          }
+        if (info.getDepth() != SVNDepth.INFINITY && warnedIfShallow.compareAndSet(false, true)) {
+          mojo.warn(
+              "Sparse svn repository detected. Year property values may not be accurate.");
         }
       }
 
       svnClientManager.getLogClient()
           .doLog(new File[]{documentFile}, SVNRevision.HEAD, SVNRevision.create(0), true, true, 1,
               lastChangeDateLogEntryHandler);
-    } catch (SVNException ex) {
-      IllegalStateException ise = new IllegalStateException("cannot query SVN latest date information for file: " + documentFile, ex);
-      throw ise;
+    } catch (SVNException e) {
+      throw new IllegalStateException("cannot query SVN latest date information for file: " + documentFile, e);
     }
 
     return newProperties;