Skip to content

Conversation

@zorkow
Copy link
Member

@zorkow zorkow commented Apr 23, 2025

Refactors code for tree coloring from SRE to the actual explorer. This reduces the footprint of code that is pulled in from SRE. I will remove more dependencies once PR #1241 is merged.

Note, that commit 04775eb only contains changes from automatic formatting and linting.

@zorkow zorkow requested a review from dpvc April 23, 2025 11:56
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the changes in your second commit for prettier changes are already in #1241. I don't know if that will cause a conflict or not (#1241 does have other changes to Menu.ts).

@zorkow
Copy link
Member Author

zorkow commented Apr 24, 2025

This looks good, but the changes in your second commit for prettier changes are already in #1241. I don't know if that will cause a conflict or not (#1241 does have other changes to Menu.ts).

Good point. I'll try to remove the last commit with pick and push. I have never done that, so it should be interesting.

@zorkow zorkow force-pushed the feature/treecolors branch from 04775eb to aa82abf Compare April 24, 2025 09:00
@zorkow
Copy link
Member Author

zorkow commented Apr 24, 2025

@zorkow zorkow merged commit 9622103 into develop Apr 24, 2025
@zorkow zorkow deleted the feature/treecolors branch April 24, 2025 09:02
@dpvc dpvc added this to the v4.0 milestone May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants