Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Aug 2, 2025

This PR moves the node-based createWorker() function from the liteAdaptor into the generic NodeMixin that is used by the liteAdaptor as well as the jsdomAdaptor and the linkedomAdaptor, so that they can support speech generation in node as well.

The code is moved unchanged, but the liteBase class gets a stub for createWorker() that is overridden in the mix-in since one is required for the AbstractDOMAdaptor class that liteBase creates before using the mixin.

@dpvc dpvc requested a review from zorkow August 2, 2025 15:42
@dpvc dpvc added this to the v4.0 milestone Aug 2, 2025
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

❌ Patch coverage is 40.81633% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.72%. Comparing base (3167719) to head (71da86f).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
ts/adaptors/NodeMixin.ts 36.36% 28 Missing ⚠️
ts/adaptors/liteAdaptor.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1328      +/-   ##
===========================================
- Coverage    86.72%   86.72%   -0.01%     
===========================================
  Files          337      337              
  Lines        84131    84139       +8     
  Branches      3139     4768    +1629     
===========================================
+ Hits         72961    72967       +6     
+ Misses       11170    11149      -21     
- Partials         0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit aacb8ff into develop Aug 4, 2025
1 of 3 checks passed
@dpvc dpvc deleted the refactor/adaptors branch August 4, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants