Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Dec 15, 2025

This PR fixes a regression in the positioning of the help icon for in-line math expression caused by the changes in #1350. The positioning in that commit cause in-line help icons to not be attached to the in-line expression, but to the nearest block-level parent.

The fix is to use the old CSS for inline math and move the new CSS to the [display="true"] selector.

@dpvc dpvc requested a review from zorkow December 15, 2025 13:45
@dpvc dpvc added this to the v4.1.0 milestone Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.48%. Comparing base (af44f98) to head (d8d8fc4).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1400   +/-   ##
========================================
  Coverage    86.48%   86.48%           
========================================
  Files          340      340           
  Lines        85818    85818           
  Branches      4815     4815           
========================================
  Hits         74218    74218           
  Misses       11577    11577           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see (sample expression $\sqrt{x}^2$ the info icon does now no longer ascend beyond the line, e.g, is on the same height as the 2 rather than in its top right hand corner (if that makes sense).
Looks better!

@dpvc dpvc merged commit 09bec73 into develop Dec 15, 2025
3 checks passed
@dpvc dpvc deleted the fix/inline-icon branch December 15, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants