Update windows paths to include file:// and fix tests. (mathjax/MathJax#3481). #1404
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
reviewed
Jan 7, 2026
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
I am getting tests errors. But maybe I am running it wrong on Windows.
| ? file.replace(/\\/g, '/').replace(/^\//, '') | ||
| : file; | ||
| ? 'file://' + file.replace(/\\/g, '/').replace(/^\//, '') | ||
| : file.replace(/^\//, 'file:///'); |
Member
There was a problem hiding this comment.
This now leads to an error in Context-node.test.ts:
Received: "file:///C:/test.js"
Member
Author
There was a problem hiding this comment.
OK, I forgot about this test (I didn't run it on windows, and that test is only performed there).
I fixed the test. I had to merge your fix/windows-tests branch to get the tests to run on windows, but that is still listed as a draft PR. Do you want to make it a full PR so we can include it in 4.1.1?
zorkow
approved these changes
Jan 8, 2026
Member
|
I've approved, but please remove that superfluous |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, importing a file from an absolute path requires the path to include the
file://protocol (that is not needed in unix and MacOS). This PR modifies thecontext.path()function that adjusts the Windows\to/to also add the neededfile://protocol for absolute references. It also adds tests to get full coverage of the changes. Finally, it adjusts theasyncLoad/system.tsfile to includefile://(though thesystem.tsfile is a legacy one that isn't really used any longer since node handles ESM loading natively).Resolves issue mathjax/MathJax#3481.