Add support for munder/mover/munderover #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
force-pushed
the
munderover-support
branch
from
bb10c51 to
ffeb86b
Compare
zorkow
reviewed
Oct 21, 2017
| } | ||
|
|
||
| /* | ||
| * Get the separation and offset for undercripts (TeXBoox Appendix G 13, 13a) |
| this.chtml = this.standardCHTMLnode(parent); | ||
| const base = this.chtml.appendChild(this.html('mjx-row')).appendChild(this.html('mjx-base')); | ||
| const under = this.chtml.appendChild(this.html('mjx-row')).appendChild(this.html('mjx-under')); | ||
| this.base.toCHTML(base); |
Member
There was a problem hiding this comment.
I find the usage of base here very confusing. In subsup/overunder base refers to a position. Here it is actually a node. Can we call it differently?
Member
Author
There was a problem hiding this comment.
I changed base to baseChild
| /* | ||
| * @return{CHTMLWrapper) The wrapped under node | ||
| */ | ||
| public get under() { |
Member
There was a problem hiding this comment.
The same comment as above applies to these fields.
Member
Author
There was a problem hiding this comment.
Changed to underChild and overChild
Member
Author
|
Changes made as per your request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary support for
munderover,munderandmover. The wrappers for these subclass the ones formsubsup,msub, andmsupbecause when they have themovablelimitsattribute, and thedisplaystyleis false, we want to set the under-over as sub-sup. This subclassing lets us call the super class in that car etc get sub-sup formatting.This PR modifies
scriptbaseclass to add the needed common functions for under-over (and moves one function in order to group things better).We also fix an issue in the CSS generated for the TeX font (where negative values for height or depth would lead to invalid
paddingvalues).This implementation doesn't yet take the
accentandaccentbelowattributes into account (which change the spacing), and doesn't do the horizontal shift needed to handle italic correction or skew. That means that limits for integrals, in particular, will be misplaced at the moment. (Italic correction still needs to be handled in general.)