Fix problem where some menu settings weren't sticky (mathjax/MathJax#2786) #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, it is. Once the explorer is on the elements need to be focusable using the tab as they now have aria role application. The in-tab-order only refers to the property of the context menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some initialization to the menu code that makes sure that the initial settings of the menu take effect on a page reload. This was not the case for the in-tab-order, assistive MML, renderer, and scale settings (argh!).
Resolves issue mathjax/MathJax#2786, and similar problems with the other settings.
@zorkow, activating the explorer seems to override the in-tab-order setting. Is that intentional?