Hotfix/improve notification test

app/Notification/AppNotificationInterface.php

@@ -5,11 +5,11 @@
 
 
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 
 interface AppNotificationInterface
 {
     public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType);
 
-    public function notify(): ResponseAdapterInterface;
+    public function notify(): HTTPResponseInterface;
 }

app/Notification/Client/Guzzle/GuzzleHTTPClient.php

@@ -5,9 +5,8 @@
 
 
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 use GuzzleHttp\Client;
-use Psr\Http\Message\ResponseInterface;
 
 class GuzzleHTTPClient implements HTTPClientAdapterInterface
 {
@@ -18,15 +17,15 @@ public function __construct()
         $this->client = new Client();
     }
 
-    public function post(string $url, array $params): ResponseAdapterInterface
+    public function post(string $url, array $params): HTTPResponseInterface
     {
-        $clientResponse = $this->client->post(
+        $guzzleResponse = $this->client->post(
             $url,
             [
                 'json' => $params
             ]
         );
 
-        return new GuzzleResponse($clientResponse);
+        return new HTTPResponse($guzzleResponse);
     }
 }

app/Notification/Client/Guzzle/GuzzleResponse.php → app/Notification/Client/Guzzle/HTTPResponse.php

@@ -4,10 +4,10 @@
 namespace App\Notification\Client\Guzzle;
 
 
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 use Psr\Http\Message\ResponseInterface;
 
-class GuzzleResponse implements ResponseAdapterInterface
+class HTTPResponse implements HTTPResponseInterface
 {
     private ResponseInterface $clientResponse;
 

app/Notification/Client/HTTPClientAdapterInterface.php

@@ -6,5 +6,5 @@
 
 interface HTTPClientAdapterInterface
 {
-    public function post(string $url, array $params): ResponseAdapterInterface;
+    public function post(string $url, array $params): HTTPResponseInterface;
 }

app/Notification/Client/HTTPResponseInterface.php

@@ -0,0 +1,14 @@
+<?php
+
+
+namespace App\Notification\Client;
+
+
+use Psr\Http\Message\ResponseInterface;
+
+interface HTTPResponseInterface
+{
+    public function __construct(ResponseInterface $clientResponse);
+
+    public function getResponse(): array;
+}

app/Notification/Slack/SlackNotification.php

@@ -6,7 +6,7 @@
 
 use App\Notification\AppNotificationInterface;
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 
 final class SlackNotification implements AppNotificationInterface
 {
@@ -19,7 +19,7 @@ public function __construct(HTTPClientAdapterInterface $client, string $message,
         $this->client  = $client;
     }
 
-    public function notify(): ResponseAdapterInterface
+    public function notify(): HTTPResponseInterface
     {
         return $this->client->post(
             getenv('SLACK_API_WEBHOOK'),

tests/Notification/Slack/FakeSlackNotificationResponse.php

@@ -0,0 +1,24 @@
+<?php
+
+
+namespace App\Test\Notification\Slack;
+
+
+use App\Notification\Client\Guzzle\HTTPResponse;
+use App\Notification\Client\HTTPResponseInterface;
+use Psr\Http\Message\ResponseInterface;
+
+class FakeSlackNotificationResponse implements HTTPResponseInterface
+{
+    private ResponseInterface $response;
+
+    public function __construct(ResponseInterface $response)
+    {
+        $this->response = $response;
+    }
+
+    public function getResponse(): array
+    {
+        return (new HTTPResponse($this->response))->getResponse();
+    }
+}

tests/Notification/Slack/FakeSlackNotificationResponseTest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace App\Test\Notification\Slack;
+
+use App\Notification\Client\HTTPResponseInterface;
+use GuzzleHttp\Psr7\Response;
+use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\TestCase;
+
+require_once 'app/DotEnvLoader/index.php';
+
+class FakeSlackNotificationResponseTest extends TestCase
+{
+    public static function test_FakeSlackNotificationResponse_ShouldAssertHTTPResponse(): void
+    {
+        $notificationResponse = new Response(
+            $statusCode = 200,
+            $responseHeader = [],
+            $responseBody = null,
+            $protocolVersion = '1.1',
+            $responseReason = 'OK'
+        );
+
+        $fakerResponse = new FakeSlackNotificationResponse($notificationResponse);
+
+        $expectedResponse = [
+            'status_code' => 200,
+            'message'     => 'OK',
+        ];
+
+        Assert::assertInstanceOf(HTTPResponseInterface::class, $fakerResponse);
+        Assert::assertEquals($expectedResponse, $fakerResponse->getResponse());
+    }
+}