added missing Num in constraints (#31)

* added missing Num in constraints * added plot as png * added information on contributions
mathopt · May 21, 2024 · fee00ec · fee00ec
1 parent bfebca6
commit fee00ec
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -3,6 +3,7 @@
 [![Latest Docs](https://img.shields.io/badge/docs-dev-blue.svg)](https://mathopt.github.io/DynamicOED.jl/dev/)
 [![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl) [![SciML Code Style](https://img.shields.io/static/v1?label=code%20style&message=SciML&color=9558b2&labelColor=389826)](https://github.com/SciML/SciMLStyle) ![Lifecycle:Experimental](https://img.shields.io/badge/Lifecycle-Experimental-339999) 
 [![Build Status](https://github.com/mathopt/DynamicOED.jl/actions/workflows/CI.yml/badge.svg?branch=main)](https://github.com/mathopt/DynamicOED.jl/actions/workflows/CI.yml?query=branch%3Amain)
+[![ColPrac: Contributor's Guide on Collaborative Practices for Community Packages](https://img.shields.io/badge/ColPrac-Contributor's%20Guide-blueviolet)](https://github.com/SciML/ColPrac)
 
 Repository for optimal experimental design for differential equations using optimal control.
 

diff --git a/docs/src/examples/1D.md b/docs/src/examples/1D.md
@@ -69,7 +69,7 @@ constraint_equations = [
 ]
 
 @named constraint_system = ConstraintsSystem(
- constraint_equations, collect(optimization_variables), []
+ constraint_equations, collect(optimization_variables), Num[]
 )
 nothing # hide
 ```

diff --git a/docs/src/examples/lotka.md b/docs/src/examples/lotka.md
@@ -65,7 +65,7 @@ constraint_equations = [
 ]
 
 @named constraint_system = ConstraintsSystem(
- constraint_equations, collect(optimization_variables), []
+ constraint_equations, collect(optimization_variables), Num[]
 )
 nothing # hide
 ```

diff --git a/docs/src/index.md b/docs/src/index.md
@@ -64,7 +64,7 @@ constraint_equations = [
  sum(optimization_variables.measurements.w₁) ≲ 3,
 ]
 
-@named constraint_set = ConstraintsSystem(constraint_equations, optimization_variables,[])
+@named constraint_set = ConstraintsSystem(constraint_equations, optimization_variables, Num[])
 
 # Initialize the optimization problem
 optimization_problem = OptimizationProblem(oed_problem, AutoForwardDiff(),

diff --git a/paper/figures/lotka.pdf b/paper/figures/lotka.pdf
diff --git a/paper/figures/lotka.png b/paper/figures/lotka.png
diff --git a/paper/paper.md b/paper/paper.md
@@ -108,7 +108,7 @@ constraint_equations = [
 ]
 
 @named constraint_system = ConstraintsSystem(
- constraint_equations, optimization_variables, []
+ constraint_equations, optimization_variables, Num[]
 )
 
 optimization_problem = OptimizationProblem(
@@ -124,7 +124,7 @@ optimal_design = solve(optimization_problem, Ipopt.Optimizer();
 
 Several extensions are planned for the future. First, a multiple shooting approach is planned. Also, other steps to increase the efficiency of our implementation may be considered. For example, in the case of fixed initial values and controls, the integration of $x$ and $G$ need to be done only once and can be decoupled from the numerical integration of $F$ and the subsequent optimization over $w$. 
 
-![Differential states, sensitivities of the states with respect to the parameters and the optimal sampling design for Lotka-Volterra system. \label{fig:lotka}](figures/lotka.pdf)
+![Differential states, sensitivities of the states with respect to the parameters and the optimal sampling design for Lotka-Volterra system. \label{fig:lotka}](figures/lotka.png)
 
 
 # Acknowledgements