Th17 - New Th, Troop, Spell, Hero, & Equipment #248
Conversation
…t (so we dont have to mess w/ downloading apk ourself)
| @@ -262,7 +264,7 @@ def in_game_name(self) -> str: | |||
|
|
|||
| SPELL_ORDER = ELIXIR_SPELL_ORDER + DARK_ELIXIR_SPELL_ORDER | |||
|
|
|||
| HOME_BASE_HERO_ORDER = ["Barbarian King", "Archer Queen", "Grand Warden", "Royal Champion"] | |||
| HOME_BASE_HERO_ORDER = ["Barbarian King", "Archer Queen", "Grand Warden", "Royal Champion", "Minion Prince"] | |||
There was a problem hiding this comment.
I would vote to keep it the order of unlocking, matching the ingame order in the hero hut, so minion prince in the middle
| "Magic Mirror" | ||
| "Magic Mirror", | ||
| "Henchmen Puppet", | ||
| "Dark Orb" |
There was a problem hiding this comment.
Please add the lavaloon puppet
| @@ -14,8 +14,7 @@ | |||
| import zipfile | |||
| from collections import defaultdict | |||
|
|
|||
| import lzma | |||
| import zstandard | |||
There was a problem hiding this comment.
good catch with the duplicate imports
| APK_URL = "https://d.apkpure.net/b/APK/com.supercell.clashofclans?version=latest" | ||
|
|
||
| def get_fingerprint(): | ||
| import aiohttp | ||
| import asyncio |
There was a problem hiding this comment.
can we move the imports all to the top? there is another one in decompress
|
Happy to hear thoughts, but does anyone actually look through the json files? Ie. do we need them "beautified"? I did a quick test and just about halved the If people actually look through them I don't hugely mind, but if we have the option it'd be nice to keep this static data small-ish for pypi and releases, and not having enormous git diffs. |
updated relevant static files & enums