Skip to content

Commit

Permalink
Do not lock again on linux
Browse files Browse the repository at this point in the history
  • Loading branch information
msmans committed Aug 31, 2022
1 parent 48dc781 commit 069ee9f
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 16 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
env:
GOARCH: ${{ matrix.arch }}
CGO_ENABLED: "1"
run: go build -ldflags="-X 'github.com/plumber-cd/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}
run: go build -ldflags="-X 'github.com/mathspace/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
with:
Expand All @@ -52,7 +52,7 @@ jobs:
env:
GOARCH: ${{ matrix.arch }}
CGO_ENABLED: "1"
run: go build -ldflags="-X 'github.com/plumber-cd/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}
run: go build -ldflags="-X 'github.com/mathspace/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
with:
Expand All @@ -78,7 +78,7 @@ jobs:
env:
GOARCH: ${{ matrix.arch }}
CGO_ENABLED: "1"
run: go build -ldflags="-X 'github.com/plumber-cd/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}.exe
run: go build -ldflags="-X 'github.com/mathspace/kubectl-credentials-helper/cmd.Version==${{ env.RELEASE_VERSION }}'" -o build/kubectl-credentials-helper-${{ matrix.os }}-${{ matrix.arch }}.exe
- name: Upload Artifact
uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This is a `kubectl` credentials helper. It is using your local OS keychain to st
To install:

```bash
go install github.com/plumber-cd/kubectl-credentials-helper
go install github.com/mathspace/kubectl-credentials-helper
```

You can also download this from releases.
Expand Down
2 changes: 1 addition & 1 deletion cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"fmt"
"os"

"github.com/plumber-cd/kubectl-credentials-helper/keychain"
"github.com/mathspace/kubectl-credentials-helper/keychain"
"github.com/spf13/cobra"
clientauthentication "k8s.io/client-go/pkg/apis/clientauthentication/v1"
"k8s.io/client-go/tools/auth/exec"
Expand Down
2 changes: 1 addition & 1 deletion cmd/secure.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"k8s.io/client-go/tools/clientcmd"
cmdApi "k8s.io/client-go/tools/clientcmd/api"

"github.com/plumber-cd/kubectl-credentials-helper/keychain"
"github.com/mathspace/kubectl-credentials-helper/keychain"
)

// OsFs is an instance of afero.NewOsFs
Expand Down
2 changes: 1 addition & 1 deletion cmd/undo.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/spf13/cobra"
"k8s.io/client-go/tools/clientcmd"

"github.com/plumber-cd/kubectl-credentials-helper/keychain"
"github.com/mathspace/kubectl-credentials-helper/keychain"
)

func init() {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/plumber-cd/kubectl-credentials-helper
module github.com/mathspace/kubectl-credentials-helper

go 1.18

Expand Down
2 changes: 1 addition & 1 deletion keychain/keychain.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package keychain

const (
Service = "Kubernetes"
AccessGroup = "github.com/plumber-cd/kubectl-credentials-helper"
AccessGroup = "github.com/mathspace/kubectl-credentials-helper"
)
6 changes: 0 additions & 6 deletions keychain/keychain_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ func CreateSecret(clusterName, clusterEndpoint, credentials string) error {
return err
}

defer func() {
_ = srv.LockItems([]dbus.ObjectPath{secretservice.DefaultCollection})
}()
if err := srv.Unlock([]dbus.ObjectPath{secretservice.DefaultCollection}); err != nil {
return err
}
Expand Down Expand Up @@ -125,9 +122,6 @@ func openItem(
return err
}

defer func() {
_ = srv.LockItems([]dbus.ObjectPath{secretservice.DefaultCollection})
}()
if err := srv.Unlock([]dbus.ObjectPath{secretservice.DefaultCollection}); err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package main
import (
"log"

"github.com/plumber-cd/kubectl-credentials-helper/cmd"
"github.com/mathspace/kubectl-credentials-helper/cmd"
)

func main() {
Expand Down

0 comments on commit 069ee9f

Please sign in to comment.