-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join clusters together... #134
Comments
I'd keep the clusters separate from the persons. I think the clusters should just be a helper to add faces to a person. But ultimately the person-face relationship should be editable so that we can also remove a relationship in case it is wrong. Google is also probably using these associations to improve their model. Can we do that as well? |
Hi @bjoern-tantau This report is just a suggestion for the future, which we will evaluate later. Now we are focused on getting an initial version with the current development.
To abstract this, we must add another complexity. However, for this to work, we must also trust in the stability of the clusters, which is still in evaluation, and we will confirm when we have more users.
No. We have to work with standardized models., Although we are aware of its limitations (Asian people, small children's, etc.), we do not have the capacity or experience to improve it. |
I also suggest to use dlib learning process: Basically:
If a user remove an image from a cluster, just mark it as removed, so future processing (clustering) of the library won't process it and, during the creation of the training images of dlib (SVM model) it won't be processed on this cluster/person. If a user move an image, just mark it as part of a different cluster and regenerate the old cluster and the cluster trained data of dlib (SVM model) So, next time, dlib will check the faces against the already trained models, if it does not match it should create a new cluster (like now). Not sure if this comment should be on this ticket or on any other related tickets. |
Hi @bjoern-tantau @xkill The suggestions of new people will be left for another PR with #262 |
In the last release, we took an important step for this issue.. I hope to move forward soon with #262 😬 😉 |
I'm seeing how Google Photos works with my photos.. It is not magic either ... it shows less results, but without errors.
The interesting thing is that the web version allows you to add photos to groups.
It only shows a notification ..
If you click theme:
If you say that it's the same person... just show another photo again..
Can not we do something similar?
It should be used in combination of this #114 and #105
How to join them?
Add an facecognition_face_joins table..
That must be filled with this dialog..
Again... How to join them? 😅
At the end of the CreateClustersTask task, check if these photos are in the same group.
Note that the main group always remains stable.. The suggested groups can mutate among themselves, and between each analysis they can provide different faces to the main group. Although they are random (Which are not so much either), If they meet the conditions of #114, they will be correct photos. The important thing is to add the face that the user said they were the same person, but the suggestions may change..
How to get the suggestions?
I do not know.. It can be a random face of the secondary groups, comparing them with a greater threshold/sensitivity?
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: