Bye bye 'New person..'

[matiasdelellis]

Ok..
This time I am not going to change the infrastructure beyond this (Just allow null names.).

So, the main changes will be in the controllers, and the fronted. Then the persons will be all the clusters with the same name... And clusters, just that.

TODO:

• Get the clusters without a name and suggest assigning one to them.
• Rename all clusters on images of person view..
• Change the sidebar panel considering in some way when it has a name and when it does not.
• Fix and improve tests.

For the future we can continue with #262 and the comparisons would be between those who have names and those who do not.

[matiasdelellis]

p.s. The idea is basically to finish some discussions about join clustering and performance. 😅

[escoand]

Good idea. And this is also the kind of view you want to integrate into images app?

[matiasdelellis]

Hi @escoand

Good idea. And this is also the kind of view you want to integrate into images app?

Yes. Hope to have something like this. However, there is no api for it yet. 😉

[matiasdelellis]

Well, for the main view this would look more or less like this..

Main view: Persons

When selecting a person: Show all photos of all clusters with the same name. Note that reuses the nextcloud thumbnails and therefore the server load is less.

If the "person" has multiple clusters, it shows the button to see them and allows rename each clusters. This allows you to correct some errors.

Clusters view

Improve sidebar: Sorted by name, unknown last, and in a lighter gray. Still need to sort them by confidence

[escoand]

OK, in the first layer you have added the "person abstraction" and show only distinct names, right? Thats effectively the often requested merge of multiple clusters with really less overhead and does not change the background work. Simple but nice solution.

But I don't understand why you show only one cluster on the second layer. Wouldn't make it more sense to show already here all clusters but allow to rename them?

But I would think the separation and rename button should be only small as this is in most cases just an onetime action.

[matiasdelellis]

HI @escoand

But I don't understand why you show only one cluster on the second layer.

They are also all clusters of one person. Count the pictures in the second and third pictures. 😉

Couldn't make it more sense to show already here all clusters but allow to rename them?

You are right, also still need to rename all the clusters of the same person in the second view. Soon... 😬

The third view is still necessary to fix grouping errors since the most common mistake is sometimes not using the last names, and 'join' two persons with the same name.. 😅

[matiasdelellis]

EDIT: When the first clusters are created, suggests assigning them names. 😬

[matiasdelellis]

With last commit change url when you select a person.
e.g. https://nextcloud.com/settings/user/facerecognition?name=Sheldon%20Cooper

So, You can put as favorites in your browser and access the photos of your favorite people with it.. 😬

@dassio, this is especially for #344

[dassio]

e.g. https://nextcloud.com/settings/user/facerecognition?name=Sheldon%20Cooper

shouldn't it be https://nextcloud.com/index.php/settings/user/facerecognition?name=Sheldon%20Cooper ?

[matiasdelellis]

e.g. https://nextcloud.com/settings/user/facerecognition?name=Sheldon%20Cooper

shouldn't it be https://nextcloud.com/index.php/settings/user/facerecognition?name=Sheldon%20Cooper ?

Yes... The public url depends on the RewriteBase configuration, but the api itself must include the index.php, however don't worry about it. Just trust on OCP\IURLGenerator.

[matiasdelellis]

@dassio in last commit add an method to get this.

I will merge this patch tomorrow. Wait and reuse all this code. 😄

[DerOetzi]

I'm very excited about this feature. When will this be available for update. Or is there the possibility to manual update to version 0.6.4?

[matiasdelellis]

Hi @DerOetzi
Thanks, We hope it meets expectations.. 😅

Surely in a couple of days I'll release the update. I just hope to merge #344 and need testers on NC20 for that. 😉

[DerOetzi]

@matiasdelellis if you can give me a hint how to test I can give it a try on my instance.

[matiasdelellis]

Hi @DerOetzi
See #343 (comment)