Nextcloud 21 compatibility #429

Derkades · 2021-02-14T10:57:28Z

Issue for tracking Nextcloud 21 compatibility. I have not tried upgrading and force enabling it yet.

dblazquezl · 2021-02-22T10:12:20Z

Hi, I already installed it with version 21, still working in the initial process of all my photos. It will take some time.

I just need to modify a couple of thing in the dockerfile in order to get the image:

1.- bz2 was not present, so I copied the 2 lines installing it to the end of the dockerfile instead in the intermediate image and then
it worked.
2.- change this path to the latest version:
COPY --from=builder /usr/local/lib/php/extensions/no-debug-non-zts-20190902/pdlib.so /usr/local/lib/php/extensions/no-
debug-non-zts-20190902/
3.- add backslash at the end of this line (it got an error without it)
COPY --from=builder /usr/local/lib/libdlib.so* /usr/local/lib/

I think that was all, I will try to update when the initial process of the images finish

markuman · 2021-02-23T20:02:57Z

I've moved from NC 20 php 7.4 to NC21 php 8.0 and it seems there is an issue with the temporary path.

Faces found: 0. Image will be skipped because of the following error: Error during image resize

any ideas? @matiasdelellis

markuman · 2021-02-23T20:19:13Z

I've patched the upstreamd nextcloud docker image like that: nextcloud/docker#1421 (comment)
It's build as nextcloud21.
And this is my multi-stage build on that for facerecognition dependencies: https://git.osuv.de/m/osuv/src/branch/main/roles/containers/files/nextcloud.Dockerfile

You can pull it from here registry.gitlab.com/markuman/container-images:home.21.0.0.1

markuman · 2021-02-23T20:30:34Z

Rolling back to php 7.4 works - even with NC21

sowoi · 2021-02-27T16:27:48Z

Yes had the same error. You need to rollback to PHP 7.4.

matiasdelellis · 2021-02-28T14:29:23Z

Hi #429
Sorry for the little development of the last time.. Much work, and honestly I was surprised by the publication of NC21.. 😞 and still haven't received the notification to install it despite having the stable channel configured .. 😅

About php 8.0, NC21 is the first version to support it, but they still recommend php 7.4. https://docs.nextcloud.com/server/21/admin_manual/installation/system_requirements.html#server, So, please, downgrade it.. 🙈

About NC21, if you do the relevant tests and assure me that it continues to work correctly, I can publish a version that enables it to install.. 😉

Derkades · 2021-03-01T09:58:23Z

I have not encountered issues on 21 yet.

and still haven't received the notification to install it despite having the stable channel configured

The rollout is slow, it can take months. Set channel to "beta" to jump to 21 immediately

Much work, and honestly I was surprised by the publication of NC21

Do you know about this page? https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule It's not updated that well but at least it gives some idea

Derkades · 2021-03-04T13:49:55Z

Found this issue, not sure if related to the Nextcloud 21 update but I haven't seen it before

szaimen · 2021-03-04T13:51:48Z

Since this is a javascript error, I don't think that it is related. But I could be wrong.

SigLinJo · 2021-03-06T22:02:01Z

I can confirm that most things seem to work in NC 21 but the persons tab in the details side-bar is not there anymore. Was present in NC 20.

matiasdelellis · 2021-03-09T12:32:46Z

I can confirm that most things seem to work in NC 21 but the persons tab in the details side-bar is not there anymore. Was present in NC 20.

D'OH!.
We must fix it. 😞

Thanks for following this ..

matiasdelellis · 2021-03-13T14:09:51Z

Hi all,
Thank to @szaimen, we enable NC21 in master, with the corresponding tests. These tests only represent the "core", which is already very important, but the fronted must be fixed separately..

I will not install NC21 on my main server yet, but I am going to see how to investigate the side panel error. Maybe with the virtual machine I can do something.

Thank you all for your patience and reports.. 😃

szaimen · 2021-03-13T14:22:42Z

Maybe with the virtual machine I can do something.

If you need an advice, this is probably the fastest way to get a NC21 VM up and running.

Here is some documentation on this: https://docs.hanssonit.se/s/W6fMouPiqQz3_Mog/virtual-machines-vm/d/W6fMquPiqQz3_Moi/nextcloud-vm-first-setup-instructions?currentPageId=W6fc6ePiqQz3_Mo3

matiasdelellis · 2021-03-13T15:22:28Z

Ok Ok..
Our Nextcloud friends did it again. 😞 😢 😭
They changed the way to register the tabs, and again it is not compatible with the previous version. Nor did they leave any kind of compatibility. 😞

See:
nextcloud/spreed#4291

The change seems to be relatively simple, but I cannot maintain compatibility even with NC20. And let me tell you that between NC13 and NC 17, I could keep a single release for all those versions!. So please understand my frustration about it! 😠 😞 😞 😭

szaimen · 2021-03-13T16:02:42Z

Unfortunate to hear that they've made it that hard for app developers to be compatible with more than the latest NC release 🙁

Though, I wonder how the metadata app is able to be compatible with so many NC versions although it must have faced the same problems when registerung the tab, as far as I understand it. 🤔
https://github.com/gino0631/nextcloud-metadata

Edit: Maybe the app can be of some help to figure some things out? :)

SigLinJo · 2021-03-13T16:04:24Z

Thank you for the effort you put in! I really appreciate face recognition in Nextcloud and it has made me rediscover a lot of pictures and memories from more than 15 years of photography. One of the best things with migrating to a more powerful home server was being able to install this! Keep up the good work!

szaimen · 2021-03-13T17:04:03Z

I can only second what @SigLinJo said. 👍
And it is one of the best Nextcloud apps, IMHO.

matiasdelellis · 2021-03-17T00:05:37Z

Unfortunate to hear that they've made it that hard for app developers to be compatible with more than the latest NC release slightly_frowning_face

Though, I wonder how the metadata app is able to be compatible with so many NC versions although it must have faced the same problems when registerung the tab, as far as I understand it. thinking
https://github.com/gino0631/nextcloud-metadata

Edit: Maybe the app can be of some help to figure some things out? :)

This application uses a "compatibility" option (OK, I have to admit that they did something about it. haha) but note that this only shows the tab in the files application. From NC17 with the new photos application, we have to use VUE to show there.. 😞

matiasdelellis · 2021-03-17T11:49:34Z

There is progress on this... 😬

Insomniacnomis · 2021-03-17T13:01:44Z

Unfortunate to hear that they've made it that hard for app developers to be compatible with more than the latest NC release slightly_frowning_face
Though, I wonder how the metadata app is able to be compatible with so many NC versions although it must have faced the same problems when registerung the tab, as far as I understand it. thinking
https://github.com/gino0631/nextcloud-metadata
Edit: Maybe the app can be of some help to figure some things out? :)

This application uses a "compatibility" option (OK, I have to admit that they did something about it. haha) but note that this only shows the tab in the files application. From NC17 with the new photos application, we have to use VUE to show there.. 😞

Maybe use the Checksum App as reference? It has a sidebar for the photos app also, and it uses VUE. I checked what has changed because it has both versions available (20 or lower, and 21), and are some small changes. But I'm a noob, so you never know

matiasdelellis · 2021-03-17T13:25:00Z

Maybe use the Checksum App as reference? It has a sidebar for the photos app also, and it uses VUE. I checked what has changed because it has both versions available (20 or lower, and 21), and are some small changes. But I'm a noob, so you never know

Ohh.. I did not test this application for a long time, and I did not know that they had migrated to vue and it worked 😄
A little hack (Same as this for php on NC20), but it can be made compatible.. 😅

Thanks you!.
However, discouraged I already migrated the server to NC21, and now i can't ensure nc20 compatibility. 😓
So, today I upload a version compatible only with nc21 😉

Derkades · 2021-03-17T14:35:32Z

Old Nextcloud versions aren't supported for that long so compatibility is not that big of a deal, especially because this facial recognition app is targeted towards home users who are probably all on 21 in a couple months anyway. (my opinion as a lazy developer)

matiasdelellis · 2021-03-17T14:58:11Z

Old Nextcloud versions aren't supported for that long so compatibility

Officially nc19 is still supported, and although it is true that the cycles are short, that is not a problem, they simply should not introduce so many incompatibilities between versions.
At least they should introduce LTS versions, where they ensure support and guaranteed compatibility!.

specially because this facial recognition app is targeted towards home users.

But it is a clear mistake of users to update so soon..

..and if you open the browser inspector console, you will also see many errors! 😞

But enough catharsis for today. 😅

Here is a test version, which only supports NC21 and finally introduces the unified search. 😉 😜

https://services.delellis.com.ar/data/facerecognition/facerecognition.tar.gz

Please, test. just replace them in the apps/facerecognition folder with this.

Derkades · 2021-03-17T15:05:34Z

Sidebar and search works after uploading the zip and running occ app:update facerecognition

markuman · 2021-03-17T15:19:31Z

But it is a clear mistake of users to update so soon..

but but but ... all the other features you're losing when you're not updating :)
I guess many updated soon because of the performance update in this case. NC21 feels a lot of faster as NC20.

matiasdelellis · 2021-03-17T18:59:57Z

but but but ... all the other features you're losing when you're not updating :)
I guess many updated soon because of the performance update in this case. NC21 feels a lot of faster as NC20.

Well, "a lot of faster as NC20.", does not mean faster than NC19. They just fixed the problems introduced in NC20. 😅

Going back to the important thing, finally publish the update: 😬

Thank you very much for the reports, contributions and words of encouragement!. 😄

Regards,
Matias

szaimen · 2021-03-17T22:54:48Z

@matiasdelellis Thank you for the new release! Because of that I was finally able to finish nextcloud/vm#1871 😊

turbotorsten · 2021-04-12T20:05:00Z

I've moved from NC 20 php 7.4 to NC21 php 8.0 and it seems there is an issue with the temporary path.
Faces found: 0. Image will be skipped because of the following error: Error during image resize
any ideas? @matiasdelellis

Is there any way to get face recognition working with php8, or is there an update coming? I am just asking so that I know if it is worth waiting for a fix or that I should just downgrade php.

matiasdelellis · 2021-04-12T22:49:27Z

Hi @Zocker1304
Unfortunately I still couldn't test php8. About our code, according to the php lintian (See https://github.com/matiasdelellis/facerecognition/runs/2175793217), it seems to be compatible with php 8.0, but there are nextcloud apis that still don't work with php 8.0.

Specifically, there are tests that fail in php 8.0, but they preferred to just ignore them rather than fix the problems.
See: nextcloud/server@d690f90#diff-59830ebc3a4184110566bf1a290d08473dfdcbd492ce498b14cd1a5e2fa2e441

Our application makes intensive use of the OC\Image class, and as you can see it fails with php 8. 😞
I have to do more research, but with that, I understand that it is a Nextcloud regression.

On the other hand, I will insist on something.

About php 8.0, NC21 is the first version to support it, but they still recommend php 7.4. https://docs.nextcloud.com/server/21/admin_manual/installation/system_requirements.html#server, So, please, downgrade it.. see_no_evil

Sorry, I know it is not a very happy answer, but at least in that, they were reasonable, and ignoring the fabulous announcement they made, in the documentation do not recommend it.

joao-p-marques · 2021-04-24T16:08:46Z

Hi, I think this is still not working perfectly, as I commented in #166 (comment)
Can this be reopened to track those problems?

matiasdelellis · 2021-04-24T16:25:18Z

@joao-p-marques
Please, don't reopen it, but open a new one and refer to them. Thanks..

szaimen mentioned this issue Mar 4, 2021

allow max-nc-version 21 and max-php-version 7.4 #434

Closed

matiasdelellis mentioned this issue Mar 13, 2021

allow max-nc-version 21 and max-php-version 7.4 #437

Merged

matiasdelellis closed this as completed Mar 17, 2021

matiasdelellis mentioned this issue Apr 9, 2021

"Backport" to NC 20 ? #455

Closed

hunterzero99 mentioned this issue Jul 13, 2021

PHP 8 support of php extension #456

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nextcloud 21 compatibility #429

Nextcloud 21 compatibility #429

Derkades commented Feb 14, 2021

dblazquezl commented Feb 22, 2021

markuman commented Feb 23, 2021

markuman commented Feb 23, 2021

markuman commented Feb 23, 2021 •

edited

Loading

sowoi commented Feb 27, 2021

matiasdelellis commented Feb 28, 2021

Derkades commented Mar 1, 2021

Derkades commented Mar 4, 2021

szaimen commented Mar 4, 2021

SigLinJo commented Mar 6, 2021

matiasdelellis commented Mar 9, 2021

matiasdelellis commented Mar 13, 2021

szaimen commented Mar 13, 2021 •

edited

Loading

matiasdelellis commented Mar 13, 2021

szaimen commented Mar 13, 2021 •

edited

Loading

SigLinJo commented Mar 13, 2021

szaimen commented Mar 13, 2021 •

edited

Loading

matiasdelellis commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Insomniacnomis commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Derkades commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Derkades commented Mar 17, 2021 •

edited

Loading

markuman commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

szaimen commented Mar 17, 2021

turbotorsten commented Apr 12, 2021

matiasdelellis commented Apr 12, 2021

joao-p-marques commented Apr 24, 2021

matiasdelellis commented Apr 24, 2021 •

edited

Loading

Nextcloud 21 compatibility #429

Nextcloud 21 compatibility #429

Comments

Derkades commented Feb 14, 2021

dblazquezl commented Feb 22, 2021

markuman commented Feb 23, 2021

markuman commented Feb 23, 2021

markuman commented Feb 23, 2021 • edited Loading

sowoi commented Feb 27, 2021

matiasdelellis commented Feb 28, 2021

Derkades commented Mar 1, 2021

Derkades commented Mar 4, 2021

szaimen commented Mar 4, 2021

SigLinJo commented Mar 6, 2021

matiasdelellis commented Mar 9, 2021

matiasdelellis commented Mar 13, 2021

szaimen commented Mar 13, 2021 • edited Loading

matiasdelellis commented Mar 13, 2021

szaimen commented Mar 13, 2021 • edited Loading

SigLinJo commented Mar 13, 2021

szaimen commented Mar 13, 2021 • edited Loading

matiasdelellis commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Insomniacnomis commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Derkades commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

Derkades commented Mar 17, 2021 • edited Loading

markuman commented Mar 17, 2021

matiasdelellis commented Mar 17, 2021

szaimen commented Mar 17, 2021

turbotorsten commented Apr 12, 2021

matiasdelellis commented Apr 12, 2021

joao-p-marques commented Apr 24, 2021

matiasdelellis commented Apr 24, 2021 • edited Loading

markuman commented Feb 23, 2021 •

edited

Loading

szaimen commented Mar 13, 2021 •

edited

Loading

szaimen commented Mar 13, 2021 •

edited

Loading

szaimen commented Mar 13, 2021 •

edited

Loading

Derkades commented Mar 17, 2021 •

edited

Loading

matiasdelellis commented Apr 24, 2021 •

edited

Loading