Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use paginated search. Fix part of issue #263 #265

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Conversation

matiasdelellis
Copy link
Owner

This should improve search speed on files.

@stalker314314 I guess this affects you.

@DrRSatzteil If you can test it, I will thank you again.. 😄

@DrRSatzteil
Copy link

I will definitely try that. One question: is it ok to just clone and make the project again or is there anything I need to know when I'm updating like this?

@DrRSatzteil
Copy link

I just gave it a try and it worked out fine. Unfortunately I rebuilt from the master branch 🙈 Will try again later...

@matiasdelellis
Copy link
Owner Author

For this change from master, you just need to do git checkout search-paged
You shouldn't even do make again,

@DrRSatzteil
Copy link

Thanks I tried from the correct branch now. However I do not see any improvement. The first query takes about a minute still. However when I search again the results are there more or less instantly. So apparently there is some cache in place somewhere. I also do not notice a difference UI-wise. It seemed to load page by page before the change already: below the list it states that there are 30 hits and after scrolling down it is corrected to 55 hits. This behaviour was the same in the master branch.

@matiasdelellis
Copy link
Owner Author

Ohh.. Just to ensure something ..
Disable this application and search for anything in files.

@DrRSatzteil
Copy link

With both fulltextsearch and facerecognition disabled I don't find any results.

@matiasdelellis
Copy link
Owner Author

Don't serach persons, because you won't find it, but search for any file by name.. I want to make sure if there is any difference in performance.. 😕

@DrRSatzteil
Copy link

Oh well other files are found very quickly no matter if the app is enabled or not. What takes a while is below that where it says: detaching in different locations (an anderen Orten suchen - in German)

@matiasdelellis
Copy link
Owner Author

Oh well other files are found very quickly no matter if the app is enabled or not. What takes a while is below that where it says: detaching in different locations (an anderen Orten suchen - in German)

Ok .. Do you have any other application that indexes the files?. I ask you because for example Music also indexes without paging. 😅 Maybe this query is now fast, but other applications cause problems. I can continue to suggest deactivating applications, but already at this point it is disappointing.
From my side I think that I cannot improve it anymore .. 😞

@DrRSatzteil
Copy link

Now I see what you're trying to find out. Well it seems that it is also searching for comments in files. This takes quite a while as well. I don't use Music however. Maybe I can test a bit tomorrow.

@matiasdelellis matiasdelellis merged commit a7ca576 into master Apr 28, 2020
@matiasdelellis matiasdelellis deleted the search-paged branch May 1, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants