Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nextcloud version to 20 #345

Merged
merged 1 commit into from
Oct 13, 2020
Merged

bump nextcloud version to 20 #345

merged 1 commit into from
Oct 13, 2020

Conversation

dassio
Copy link
Contributor

@dassio dassio commented Oct 11, 2020

CI BUILD: https://travis-ci.com/github/dassio/facerecognition/builds/189297176

Edit:
i also did an manual test, it seems to be ok

Copy link
Owner

@matiasdelellis matiasdelellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dassio
Thank you very much for split the patch.. Returns the test of NC 19 and we merge it. 😄

.travis.yml Show resolved Hide resolved
@matiasdelellis
Copy link
Owner

p.s: I was worried about the new Bootstraping process but it seems optional. https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html#bootstrapping

@dassio
Copy link
Contributor Author

dassio commented Oct 13, 2020

p.s: I was worried about the new Bootstraping process but it seems optional. https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html#bootstrapping

yes, i am trying to find a way so that we can active the unified search but also be compatible with NC19

Signed-off-by: xiangbin.li <dassio@icloud.com>
@matiasdelellis
Copy link
Owner

yes, i am trying to find a way so that we can active the unified search but also be compatible with NC19

Yes,, Please.. 😄

See:

@matiasdelellis matiasdelellis merged commit aabe0b3 into matiasdelellis:master Oct 13, 2020
@matiasdelellis
Copy link
Owner

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants