refactor: use only one target as a limit order #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matiasvillaverde
commented
Jun 3, 2023
matiasvillaverde
commented
- refactor: save target as a limit order
- feat: Add fee field to Stop and Target dialogs in trust-cli dispatcher.rs.
…r.rs. - Add fee field to Stop and Target dialogs - Changes made to dispatcher.rs - Omitted some big changes in the diff summary - Improvements to create_stop and create_target functions
… unnecessary parameters. - Refactored various methods in different files to improve code readability and maintainability. - Introduced a new `DraftTrade` struct and modified the `create_trade` function to use `DraftTrade` object instead of individual parameters for stop price, entry price, and target price. - Removed unnecessary parameters, methods, and types to simplify the codebase. - Improved user input validation in the `quantity` method of the trade dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.