fix: sync between Alpaca orders and trust orders #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor order mapping logic in trust-broker/src/order_mapper.rs - Improve code readability and maintainability - Optimize performance for large order sets - Fix minor bugs and inconsistencies in the code - Update documentation in affected files
Refactor `map_trade_status()` and remove unused for loop in `order_mapper.rs` - Use `any()` instead of for loops and `clone()` method in `map_trade_status()` - Remove unused for loop in `map_trade_status()`
- Ensure matching order IDs are checked before modifying orders - Correctly map numeric values for `filled_quantity` and `average_fill_price` - Map order status from Alpaca API status - Add tests for key mapping functions - Add `map_orders` function to convert `AlpacaOrder` to `Vec<Order>`
- Refactor order mapping functionality in trust-broker/src/order_mapper.rs - Improve code readability and maintainability - Update variable and function names to be more descriptive and consistent - Fix edge case bugs related to order status handling - Increase test coverage for the order mapper module
- Refactor mapping code in order_mapper.rs for target and stop orders - Replace for loop and if-else statements with extend and filter_map methods - Optimize code for enhanced performance and readability
- Refactor `map_orders` into a separate `order_mapper` module - Update `sync_trade` to use new `order_mapper` module - Add `map_trade_status` to `order_mapper` - Remove `TODO` and `tests` modules - No changes to the actual code logic
- Add `read_api_key` function to `keys` module for reading API keys - Implement `AsyncBroker` trait for using async functions - Remove unused `apca::ApiInfo` import - Move `read_api_key` function to `keys` module - Turn `submit` function into an async function - Clean up unnecessary assertions in functions
- Add `find_entry` function for finding the entry order of a trade by id - Refactor `sync_trade` to use `find_entry` - Include unit tests for `find_entry` - Other minor changes and improvements in `sync.rs`
…capabilities Refactor `find_entry` function and improve test coverage - Use `ok_or_else` in place of match for better error handling - Remove unused import to clean up code - Add 2 unit tests to improve coverage of `find_entry` function
- Copy `trust-broker/src/lib.rs` to `trust-broker/src/submit_trade.rs` with 78% similarity - Remove `Broker` trait implementation and `submit_trade` function from `AlpacaBroker` - Add `submit_sync` and `submit` functions to submit trades synchronously and asynchronously respectively - Remove `sync_trade`, `setup_keys`, `read_keys`, and `delete_keys` functions from `AlpacaBroker` - Add functions to `sync.rs` for syncing with Alpaca and finding entry orders from closed orders.
- Refactor code for better naming consistency and clarity - Remove unnecessary assertion check in sync_trade function - Modularize Client initialization for easier maintenance - Add API credentials retrieval function in sync_trade.rs - Verify trade is for correct account in sync function - Wrap sync_trade in a Runtime for non-blocking call - Return updated Status and Vec<Order> from sync function - Remove unnecessary pub keyword from sync_trade - Add comment indicating excluded get_closed_orders function.
- Add `serde_json` dependency to project for JSON logging - Refactor code to use entry order's ID for `client_order_id` - Simplify and remove unused code in `LogView` - Adjust error message in `find_entry` function for clarity - Add and update tests for relevant functions
…flow. - Refactor code in submit_trade.rs and sync_trade.rs - Improve order object returned by default function - Simplify tests by removing unnecessary orders - Update id assignment to entry_order object - Add assertion to test for correct error message in test_find_entry_does_not_exist
- Update `submit_trade.rs` - Fix issue with incorrect handling of leg prices in `extract_ids` function - Improve functionality and ensure correct pricing in all trade submissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any()method.submit_tradefunction