feature: save logs from sync #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matiasvillaverde
commented
Jun 15, 2023
matiasvillaverde
commented
- feat: Refactor trade syncing to include broker logs
- feat: Improve trade syncing functionality and error handling.
- Refactored `create_trade` method to use `DraftTrade` struct for improved readability - Added new `sync_trade` method to sync trades with broker and update orders, with the ability to save broker log in database - Improved error handling with better types and error messages - Modified return types of `sync_trade` methods in multiple files to include `BrokerLog` struct - Added new trade steps for different stages in trade process and new method to update target price - Improved formatting and readability with multi-line function parameter formatting
- Add LogView to display broker logs during trade sync - Update sync_trade function to return a BrokerLog - Add error handling for account search in SyncTradeDialogBuilder - Improve create_trade function to handle new order types - Refactor integration test functions, removing unnecessary print statements and simplifying code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.