refactor: improve validation of actions by adding more unit tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matiasvillaverde
commented
Jun 23, 2023
matiasvillaverde
commented
- refactor: Refactor trade validation and funding validation modules
- refactor: Refactor transaction processing functions and validators
- refactor: Refactor funding validator function in trust core.
- Create separate modules in `validators.rs` for `trade_validator`, `funding_validator`, and `rule_validator` - Rename `RuleValidator` to `trade_validator` - Update several methods to return more results - Refactor `create_rule` function in `rule_worker.rs` to use `can_create` function from `rule_validator.rs` - Simplify validation of existing rules in `can_create` function of `rule_validator.rs`
- Refactor transaction worker functions - Remove trade_db from deposit and withdraw functions - Remove TransactionCategory::FundTrade call from several functions - Create transactions and update overviews in multiple functions - Remove validate_trade function from transaction validator - Remove TransactionCategory::FundTrade from match statement in validate function
- Refactor funding_validator.rs for readability and maintainability - Remove unnecessary return statement - Use curly braces for clearer code - Clean up error message formatting for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.