refactor: naming of crates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matiasvillaverde
commented
Jun 23, 2023
matiasvillaverde
commented
- refactor: rename packages to not prefix trust
- refactor: rename validators
- refactor: Refactor and organize imports throughout the project.
- refactor: Refactor transaction validation and update transaction categories
- Refactor and reorder various imports in multiple modules for better readability - Remove unused imports and variables in several modules - Add missing imports for Decimal and Uuid types in some modules - Add new validation methods in the validation module for deposits, withdrawals, fills, fees, and closes - Rename and change access modifier for a function in the rule_worker module - Remove obsolete validation method in the transaction_worker module - Refactor the create_rule function to improve readability in the rule_worker module - Move some model imports to the top of the file for easier understanding in the order_mapper and close_trade modules
…gories - Refactored transaction validation functions to use `can_transfer` prefix instead of `validate` - Renamed `TransactionWorker` to `TransactionController` - Split payment from trade into separate function - Added new transaction categories including trade ID and slippage - Updated multiple overviews after transactions
- Refactored and renamed several traits and methods for better code organization and clarity - Updated method calls and imports to accommodate the changes in file structure and naming conventions - Improved code readability and removed unnecessary assertions - Modified various function signatures to use `dyn` trait instead of separate traits for each database operation - Removed unused function and files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.