feat: Refactor code structure and imports #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine multiple functions in `core/src/lib.rs` into single modules for better organization and readability - Modify `core/src/validators/funding.rs` to update validation for trade capital and rules - Reorder and remove unnecessary imports in various files to improve code cleanliness and consistency
- Renamed the `can_cancel` function to `can_cancel_funded` - Added a new function `can_cancel_submitted` with tests - Modified test `test_validate_cancel_not_funded` to use `can_cancel_funded` - Added new methods to `TrustFacade` struct: `create_account`, `search_account`, `search_all_accounts`, `search_all_rules`, `create_transaction`, `search_overview`, `search_all_overviews`, `create_rule`, `deactivate_rule`, `search_rules`, `create_trading_vehicle`, `search_trading_vehicles`, `calculate_maximum_quantity`, `create_trade`, `search_trades`, `fund_trade`, `submit_trade`, `sync_trade`, `fill_trade`, `stop_trade`, `close_trade`, `cancel_funded_trade`, `cancel_submitted_trade`, `target_acquired`
- Added new functions to the `MockBroker` implementation for canceling trades, submitting trades, syncing trades, and closing trades. - Added various methods to the `TrustFacade` struct for creating and searching accounts, rules, transactions, overviews, trading vehicles, and trades. - Implemented a `cancel_trade` method in the `Broker` trait and added it to the `AlpacaBroker` and `MockBroker` implementations. - Created a new file `cancel_trade.rs` in the `alpaca-broker` module to handle trade cancellation logic. - Introduced error handling in the `cancel_entry` function of the `cancel_trade` module. - Added test cases for the `cancel_trade` function in the `integration_test_cancel_trade.rs` and `integration_test_account.rs` files. - Restructured the `cancel_trade` implementation in the `AlpacaBroker` by moving it to a separate file.
…trades, and trading vehicles - Add new methods to the `TrustFacade` struct for creating and searching accounts, rules, trading vehicles, and trades. - Implement methods for handling trade events, such as funding, submission, syncing, filling, stopping, and closing trades. - Add a method to calculate the maximum quantity for a trade. - Implement methods for canceling funded and submitted trades. - Add a method for handling target acquired trade events.
- Added debug print statements for easier troubleshooting - Improved logging in `cancel_trade` function - Made changes to improve code readability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/src/lib.rsinto single modules for better organization and readabilitycore/src/validators/funding.rsto update validation for trade capital and rules