feat: update targets #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new `modify-target` command to modify the target order of a filled trade - Renamed and refactored various files and methods for consistency and clarity - Implemented the `modify_target` method in the `TradeCommandBuilder` and `TrustFacade` - Updated the `ModifyDialogBuilder` method in the `dispatcher.rs` file to include the option to modify the target price of a trade
- Added a new function `can_modify_target` for validating modifications to the trade target in `trade.rs` - Implemented validation for `can_modify_target` based on the trade's status - Modified the `modify_target` function in the `MockBroker` implementation and added a new parameter `new_target_price` - Created assertions to check if the `account_id`, `trade.target.unit_price`, and `new_target_price` are equal in the `modify_target` function - Added a `modify_target` function to the `AlpacaBroker` struct in `lib.rs` - Modified the `modify_stop` function to take a `new_stop_price` parameter in `lib.rs` - Added a new method `modify_target` to the `Broker` trait interface in `broker.rs` - Added a new method `modify_target` to the `MockBroker` struct in `integration_test_account.rs` - Added a `modify_target` function to the `Broker` trait implementation in `integration_test_cancel_trade.rs` - Modified the `modify_stop` function to the more general `modify` function in `order_worker.rs` - Updated the parameter names in the `modify` function to be more descriptive and fixed the return type in `order_worker.rs` - Added a new method `modify_target` to the `TradeAction` struct and modified the `modify_stop` method to call the `OrderWorker` method `modify` in `trade_action.rs` - Added import statements for `BrokerLog`, `can_modify_target` and `can_modify_stop` in `trade_action.rs` - Added a `modify_target` function to the `TrustFacade` struct in `lib.rs`
- Added new modules for modifying stop price and target price in a trade - Replaced old modules with new ones for modifying stop price and target price - Removed code related to modifying target prices - Modified the TradeAction struct and its methods for handling trade status updates, fee payments, fund transfers, and order creation - Renamed and modified functions and parameters in the modify_trade.rs file - Updated the function signatures and removed unused code in the trade.rs file's validators and tests
- Added a new integration test for modifying the target price of a trade - Modified the `modify_target` function in the `MockBroker` implementation - Changed the initial target price of the trade in the `modify_target` function test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify_targetfunction in brokers and workersmodify_targetfunction