Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chg: upgrade deps and solve sec issues #1261

Merged
merged 3 commits into from
Jun 10, 2024
Merged

chg: upgrade deps and solve sec issues #1261

merged 3 commits into from
Jun 10, 2024

Conversation

marcello33
Copy link
Contributor

Description

In this PR, we upgrade some dependencies, change the code accordingly where required, and fixed some bugs.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@marcello33 marcello33 requested a review from a team June 10, 2024 13:39
@marcello33 marcello33 merged commit 97529db into v1.4.0-beta-candidate Jun 10, 2024
8 of 9 checks passed
pratikspatil024 pushed a commit that referenced this pull request Jun 13, 2024
@marcello33 @pratikspatil024
chg: upgrade deps and solve sec issues (#1261)
a9e5c95 
* chg: upgrade deps and solve sec issues

* chg: use old kzg-4844 repo

* chg: ignore explicitly Errorf return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manav2401 manav2401 manav2401 approved these changes

@cffls cffls cffls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @manav2401 @cffls