chg: update the enforced 30gwei for gas related configs to 25gwei #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcello33
approved these changes
Jun 27, 2024
ssandeep
reviewed
Jun 27, 2024
| @@ -84,7 +84,7 @@ func generateMergeChain(n int, merged bool) (*core.Genesis, []*types.Block) { | |||
| generate := func(i int, g *core.BlockGen) { | |||
| g.OffsetTime(5) | |||
| g.SetExtra([]byte("test")) | |||
| tx, _ := types.SignTx(types.NewTransaction(testNonce, common.HexToAddress("0x9a9070028361F7AAbeB3f2F2Dc07F82C4a98A02a"), big.NewInt(1), params.TxGas, big.NewInt(params.InitialBaseFee*32), nil), types.LatestSigner(&config), testKey) | |||
| tx, _ := types.SignTx(types.NewTransaction(testNonce, common.HexToAddress("0x9a9070028361F7AAbeB3f2F2Dc07F82C4a98A02a"), big.NewInt(1), params.TxGas, big.NewInt(params.InitialBaseFee*26), nil), types.LatestSigner(&config), testKey) | |||
There was a problem hiding this comment.
Why does this have to be changed to 26?
There was a problem hiding this comment.
@ssandeep, I have a comment in the code for the tests, reporting it here
Given the introduction of `BorDefaultTxPoolPriceLimit=30gwei`,
we set `testTxPoolConfig.PriceLimit = 1` to avoid rewriting all `legacypool_test.go` tests,
causing code divergence from geth, as this has been widely tested on different networks.
Also, `worker_test.go` has been adapted to reflect such changes.
Furthermore, config test can be found in `TestTxPoolDefaultPriceLimit`
Basically we adopted some workarounds not to change the whole structure of tests.
In this one specifically, with fee=1, geth used 2 to make the test pass.
With 30gwei I just modified it to be 32.
So now with 25, changing it to something just higher than it would work.
pratikspatil024
force-pushed
the
psp-25gwei
branch
from
25fac0e
to
929065c
Compare
|
Closing in favour of bor#1285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR, please do not merge it yet. Thanks!
This PR updated the enforced 30gwei gas for txpool.pricelimit, miner.gasprice and gpo.ignoreprice to 25gwei.
Previous PR - maticnetwork/bor#1264
PR in erigon - ledgerwatch/erigon#10930
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it