Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-35: enforce gas related configs for mainnet #1290

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

manav2401
Copy link
Contributor

Description

This PR generalises the 25 gwei gas enforcement (based on PIP-35) to all networks (i.e. specifically polygon mainnet). Earlier, it was only introduced to amoy. This PR removes those checks such that it's applicable to mainnet as well.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

The values txpool.pricelimit, miner.gasprice and gpo.ignoreprice are now enforced to 25 gwei

Nodes audience

Applicable to all

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 marked this pull request as ready for review July 16, 2024 08:37
docs/cli/example_config.toml Outdated Show resolved Hide resolved
docs/cli/example_config.toml Outdated Show resolved Hide resolved
docs/cli/example_config.toml Outdated Show resolved Hide resolved
eth/backend.go Show resolved Hide resolved
eth/gasprice/gasprice.go Show resolved Hide resolved
@manav2401 manav2401 merged commit dce4253 into 1.3.4-candidate Jul 23, 2024
8 of 9 checks passed
@manav2401 manav2401 deleted the manav/remove-amoy-enforcements branch July 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants