Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable developer mode for new cli #309

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Enable developer mode for new cli #309

merged 5 commits into from
Jan 28, 2022

Conversation

manav2401
Copy link
Contributor

@manav2401 manav2401 commented Jan 21, 2022

This PR enables the developer mode for the new cli.

It introduces 2 flags, --dev and --dev.period for testing purpose by starting a mining node with dummy account.

Linear: POS 151: Run new cli in dev mode

@manav2401
Copy link
Contributor Author

@vcastellm I've removed the Fatalf and have instead returned the function with an error using fmt.Errorf().

@manav2401 manav2401 requested review from ferranbt and removed request for ferranbt January 25, 2022 11:19
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manav2401 manav2401 merged commit fe21391 into master Jan 28, 2022
@manav2401 manav2401 deleted the manav/dev-mode branch January 28, 2022 12:33
@manav2401 manav2401 restored the manav/dev-mode branch January 28, 2022 13:29
@manav2401 manav2401 deleted the manav/dev-mode branch January 28, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants