Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo while fetching data from heimdall #349

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

jdkanani
Copy link
Contributor

No description provided.

vcastellm
vcastellm previously approved these changes Mar 10, 2022
temaniarpit27
temaniarpit27 previously approved these changes Mar 14, 2022
@manav2401
Copy link
Contributor

Can this be included in #359?

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #349 (1c4e025) into master (8e3d66c) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   57.51%   57.61%   +0.10%     
==========================================
  Files         553      553              
  Lines       65892    65892              
==========================================
+ Hits        37898    37966      +68     
+ Misses      24796    24729      -67     
+ Partials     3198     3197       -1     
Impacted Files Coverage Δ
consensus/bor/rest.go 0.00% <0.00%> (ø)
trie/proof.go 74.11% <0.00%> (-1.07%) ⬇️
eth/downloader/queue.go 78.72% <0.00%> (-0.54%) ⬇️
les/downloader/downloader.go 75.78% <0.00%> (-0.32%) ⬇️
eth/downloader/downloader.go 75.46% <0.00%> (ø)
eth/protocols/snap/sync.go 72.67% <0.00%> (+0.22%) ⬆️
miner/worker.go 69.49% <0.00%> (+0.40%) ⬆️
accounts/keystore/keystore.go 76.64% <0.00%> (+0.50%) ⬆️
p2p/peer.go 75.25% <0.00%> (+1.01%) ⬆️
eth/handler_eth.go 40.44% <0.00%> (+1.12%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3d66c...1c4e025. Read the comment docs.

@temaniarpit27 temaniarpit27 merged commit 44603db into master Apr 20, 2022
@temaniarpit27 temaniarpit27 deleted the jdkanani/fix-typo-log branch April 20, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants