internal/cli/server, eth: add option to disable personal wallet endpoints #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.3.0-dev #394 +/- ##
==============================================
- Coverage 55.79% 55.74% -0.06%
==============================================
Files 601 601
Lines 69535 69585 +50
==============================================
- Hits 38800 38789 -11
- Misses 27377 27448 +71
+ Partials 3358 3348 -10
Continue to review full report at Codecov.
|
POS-31 Deprecate personal/wallet endpoints from Bor
We still need to run this by the community to figure out if there is anyone using these features. https://www.notion.so/polygontechnology/RFC-21-73e62b51690d459688b0bef0c8335ccd |
JekaMas
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag called disable-bor-wallet in the new-cli, which in-turn disables the rpc endpoints with personal namespace. Basically it won't allow the users to perform any wallet related operation. Incase it's a mining node, it will perform the authorisation using a dummy account manager.
Note: The endpoints will still exist and will also show up in the list of commands. It's just that the account manager has no keystore and hence those endpoints will be of no use.
The changes have been tested for developer mode as well as normal mode.