Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and enable 'unlock' flag #403

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

cffls
Copy link
Contributor

@cffls cffls commented May 16, 2022

Currently in v0.3.0, validator couldn't mine new blocks, because the mining account is locked even when passed to "-unlock" flag. This commit will respect the functionality of flags "-unlock", "-password", and "-allow-insecure-unlock".

Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cffls cffls merged commit cd1a899 into maticnetwork:v0.3.0-dev May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants