Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging for statesyncs data #407

Merged
merged 7 commits into from
May 23, 2022
Merged

Added logging for statesyncs data #407

merged 7 commits into from
May 23, 2022

Conversation

0xsharma
Copy link
Contributor

Added the following logs in Bor:

  • Number of state-syncs in a given sprint.
  • Total gas used by state-syncs in Bor.

Linear Task Link

@linear
Copy link

linear bot commented May 20, 2022

POS-374 Add logging in datadog for state sync

We need to start logging additional details about state sync for helping in debugging. We can create a notion page to discuss if this linear task is not sufficient.

  1. time to fetch Heimdall state syncs in bor
  2. number of attempts before a successful fetching state sync transactions
  3. how many state sync transactions were fetched in total for a span
  4. gas used in bor

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #407 (59337a7) into master (f083705) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   56.71%   56.77%   +0.06%     
==========================================
  Files         578      578              
  Lines       68317    68326       +9     
==========================================
+ Hits        38743    38793      +50     
+ Misses      26219    26191      -28     
+ Partials     3355     3342      -13     
Impacted Files Coverage Δ
consensus/bor/bor.go 6.15% <0.00%> (-0.08%) ⬇️
consensus/bor/clerk.go 0.00% <0.00%> (ø)
consensus/bor/errors.go 0.00% <0.00%> (ø)
consensus/bor/genesis_contracts_client.go 0.00% <0.00%> (ø)
rpc/ipc.go 61.53% <0.00%> (-15.39%) ⬇️
rpc/server.go 72.50% <0.00%> (-5.00%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
trie/proof.go 73.94% <0.00%> (-0.71%) ⬇️
p2p/server.go 65.02% <0.00%> (-0.43%) ⬇️
core/tx_pool.go 70.94% <0.00%> (-0.41%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f083705...59337a7. Read the comment docs.

@0xsharma 0xsharma marked this pull request as draft May 20, 2022 07:52
JekaMas
JekaMas previously approved these changes May 20, 2022
@0xsharma 0xsharma requested a review from vcastellm May 23, 2022 05:29
@temaniarpit27 temaniarpit27 marked this pull request as ready for review May 23, 2022 09:29
@0xsharma 0xsharma merged commit 8c3423c into master May 23, 2022
@0xsharma 0xsharma deleted the POS-374 branch May 23, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants