eth: fix whitelist/requiredblocks regression - v0.3.x #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manav2401
changed the title
temaniarpit27
approved these changes
Aug 17, 2022
JekaMas
approved these changes
Aug 17, 2022
|
How do you think that kind of test do we need to catch that issue? |
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Aug 17, 2022
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in checking blocks (and hash) set using the
--requiredblocksflag in the new cli.Reference: ethereum/go-ethereum#24817
Jira - [v0.2.16 and v0.3.0] Required block mismatch when whitelist blocks are provided