rpc, ethclient: cater 'finalized' and 'safe' blocks in ethclient (v0.3.x) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rpc: add finalized and safe block types * ethclient: honour safe and finalized block requests * fix: remove BlockByNumberWithoutTx function
temaniarpit27
approved these changes
Sep 22, 2022
0xsharma
approved these changes
Sep 22, 2022
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Sep 29, 2022
…icnetwork#517) (maticnetwork#523) * rpc: add finalized and safe block types * ethclient: honour safe and finalized block requests * fix: remove BlockByNumberWithoutTx function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks commits from #517 PR which was done for v0.2.18-candidate.
This PR adds new block type for "finalized and "safe" blocks to honour the post-merge API modifications.
The purpose behind this change is to consume this client in heimdall for L1 communication i.e. ethereum mainnet and goerli test network which are already following these notions.
Reference implementation from geth: ethereum/go-ethereum#24282, ethereum/go-ethereum#25165, ethereum/go-ethereum#25580.
NOTE: This by no means adds/serves "finalized" or "safe" blocks from bor.