Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default value of maxpeers from 200 to 50, update docs #555

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

pratikspatil024
Copy link
Member

@pratikspatil024 pratikspatil024 commented Oct 18, 2022

@pratikspatil024 pratikspatil024 requested a review from a team October 18, 2022 09:34
@manav2401 manav2401 changed the title Changed default value of maxpeers from 200 to 50 Changed default value of maxpeers from 200 to 50, update docs Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 56.87% // Head: 56.82% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (70cc544) compared to base (02e84ff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #555      +/-   ##
===========================================
- Coverage    56.87%   56.82%   -0.05%     
===========================================
  Files          606      606              
  Lines        70128    70128              
===========================================
- Hits         39882    39850      -32     
- Misses       26829    26855      +26     
- Partials      3417     3423       +6     
Impacted Files Coverage Δ
internal/cli/server/config.go 73.04% <100.00%> (ø)
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
les/distributor.go 75.78% <0.00%> (-3.91%) ⬇️
core/state/trie_prefetcher.go 74.80% <0.00%> (-3.82%) ⬇️
eth/protocols/snap/sync.go 70.07% <0.00%> (-1.43%) ⬇️
les/odr.go 89.02% <0.00%> (-1.22%) ⬇️
p2p/simulations/mocker.go 30.00% <0.00%> (-1.12%) ⬇️
rpc/handler.go 89.24% <0.00%> (-1.08%) ⬇️
miner/worker.go 72.62% <0.00%> (-0.95%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pratikspatil024 pratikspatil024 merged commit e17ee36 into develop Oct 21, 2022
@pratikspatil024 pratikspatil024 deleted the pratik/pos-926 branch October 21, 2022 03:24
cffls pushed a commit to cffls/bor that referenced this pull request Oct 21, 2022
…etwork#555)

* changed default of maxpeers from 200 to 50

* docs: update additional notes for new-cli

* docs: update additional notes for new-cli

* small bug fix in the script to fix shopt issue

Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants