Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix: ci #559

Merged
merged 5 commits into from
Oct 20, 2022
Merged

dev: fix: ci #559

merged 5 commits into from
Oct 20, 2022

Conversation

marcello33
Copy link
Contributor

Description

Fix ci with latest matic-cli

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 56.87% // Head: 56.87% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f88b14c) compared to base (02e84ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #559   +/-   ##
========================================
  Coverage    56.87%   56.87%           
========================================
  Files          606      606           
  Lines        70128    70128           
========================================
+ Hits         39882    39887    +5     
+ Misses       26829    26820    -9     
- Partials      3417     3421    +4     
Impacted Files Coverage Δ
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
les/pruner.go 60.71% <0.00%> (-3.58%) ⬇️
consensus/ethash/algorithm.go 88.81% <0.00%> (-2.64%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-1.46%) ⬇️
les/odr.go 89.02% <0.00%> (-1.22%) ⬇️
p2p/simulations/mocker.go 30.00% <0.00%> (-1.12%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
consensus/ethash/consensus.go 40.21% <0.00%> (-0.72%) ⬇️
les/fetcher/block_fetcher.go 84.07% <0.00%> (-0.53%) ⬇️
core/tx_pool.go 70.41% <0.00%> (-0.41%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcello33 marcello33 marked this pull request as ready for review October 20, 2022 08:18
@marcello33 marcello33 merged commit c954606 into develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants