Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of 0.3.0 package changes, control file updates, postinst chang… #613

Merged

Conversation

djpolygon
Copy link
Contributor

…es, and packager update

Description

Please provide a detailed description of what was done in this PR

Changes

  • [ x] Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov-commenter
Copy link

Codecov Report

Base: 56.76% // Head: 56.73% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (dab3161) compared to base (742990c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           arpit/v0.3.1-mumbai-candidate     #613      +/-   ##
=================================================================
- Coverage                          56.76%   56.73%   -0.03%     
=================================================================
  Files                                607      607              
  Lines                              70310    70310              
=================================================================
- Hits                               39908    39889      -19     
- Misses                             26981    26995      +14     
- Partials                            3421     3426       +5     
Impacted Files Coverage Δ
consensus/ethash/ethash.go 51.90% <0.00%> (-4.59%) ⬇️
p2p/enode/iter.go 88.34% <0.00%> (-2.92%) ⬇️
les/utils/exec_queue.go 88.88% <0.00%> (-2.78%) ⬇️
core/rawdb/freezer_batch.go 77.21% <0.00%> (-2.54%) ⬇️
les/distributor.go 79.68% <0.00%> (-2.35%) ⬇️
p2p/peer.go 73.63% <0.00%> (-1.00%) ⬇️
eth/downloader/downloader.go 70.47% <0.00%> (-0.95%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
trie/proof.go 73.94% <0.00%> (-0.71%) ⬇️
miner/worker.go 72.94% <0.00%> (-0.64%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djpolygon djpolygon merged commit 5d6ffa7 into arpit/v0.3.1-mumbai-candidate Dec 4, 2022
@djpolygon djpolygon deleted the djpolygon/v0.3.1-mumbai-update branch December 4, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants