Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ancient datadir flag and toml field #614

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

pratikspatil024
Copy link
Member

@pratikspatil024 pratikspatil024 commented Dec 4, 2022

Added ancient datadir flag and toml field

TODO

  • need to decide on default value
  • update the conversion script

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Base: 56.83% // Head: 56.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (531d67a) compared to base (6cd5d15).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa     #614   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files         598      598           
  Lines       69215    69223    +8     
=======================================
+ Hits        39341    39346    +5     
- Misses      26520    26522    +2     
- Partials     3354     3355    +1     
Impacted Files Coverage Δ
internal/cli/server/config.go 72.09% <33.33%> (-0.28%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
core/state_prefetcher.go 85.18% <0.00%> (-7.41%) ⬇️
eth/downloader/modes.go 17.24% <0.00%> (-6.90%) ⬇️
core/state/trie_prefetcher.go 74.80% <0.00%> (-3.82%) ⬇️
consensus/ethash/ethash.go 53.05% <0.00%> (-2.68%) ⬇️
p2p/peer.go 73.63% <0.00%> (-1.00%) ⬇️
eth/filters/api.go 41.13% <0.00%> (-0.71%) ⬇️
eth/downloader/fetchers_concurrent.go 53.74% <0.00%> (-0.69%) ⬇️
p2p/simulations/http.go 66.02% <0.00%> (-0.65%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@temaniarpit27 temaniarpit27 marked this pull request as ready for review December 4, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start new bor client v0.3.0 with datadir.ancient flag
4 participants