Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.5 #767

Merged
merged 6 commits into from
Mar 6, 2023
Merged

v0.3.5 #767

merged 6 commits into from
Mar 6, 2023

Conversation

cffls
Copy link
Contributor

@cffls cffls commented Mar 6, 2023

Description

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@cffls cffls changed the title Jerryc/v0.3.5 v0.3.5 candidate Mar 6, 2023
@cffls cffls requested a review from a team March 6, 2023 17:17
@cffls cffls changed the title v0.3.5 candidate v0.3.5 Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.02 ⚠️

Comparison is base (4561012) 56.71% compared to head (318b7fa) 56.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   56.71%   56.70%   -0.02%     
==========================================
  Files         609      609              
  Lines       70689    70695       +6     
==========================================
- Hits        40092    40088       -4     
- Misses      27158    27179      +21     
+ Partials     3439     3428      -11     
Impacted Files Coverage Δ
params/version.go 36.84% <ø> (ø)
core/vm/contracts.go 77.65% <72.72%> (-0.19%) ⬇️
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
rpc/server.go 60.71% <0.00%> (-3.58%) ⬇️
les/distributor.go 79.68% <0.00%> (-3.13%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-1.46%) ⬇️
p2p/simulations/mocker.go 30.00% <0.00%> (-1.12%) ⬇️
rpc/handler.go 89.52% <0.00%> (-1.05%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cffls cffls merged commit 7db8c14 into maticnetwork:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants