Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm, miner : Make commitInterrupt OPCODE level #794

Merged
merged 25 commits into from
May 1, 2023
Merged

Conversation

0xsharma
Copy link
Contributor

Description

In this PR, we make CommitInterruptExperiment (#556) to OPCODE level.

core/state_processor.go Outdated Show resolved Hide resolved
@0xsharma 0xsharma requested review from JekaMas and a team April 5, 2023 14:03
accounts/abi/bind/backends/simulated.go Outdated Show resolved Hide resolved
core/state_prefetcher.go Outdated Show resolved Hide resolved
core/state_processor.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 59.89% and project coverage change: -0.03 ⚠️

Comparison is base (6dee9b5) 56.68% compared to head (8e8efb9) 56.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    56.68%   56.66%   -0.03%     
===========================================
  Files          611      611              
  Lines        72228    72430     +202     
===========================================
+ Hits         40943    41041      +98     
- Misses       27790    27887      +97     
- Partials      3495     3502       +7     
Impacted Files Coverage Δ
core/vm/instructions.go 24.74% <0.00%> (ø)
eth/state_accessor.go 0.00% <0.00%> (ø)
eth/tracers/api_bor.go 0.00% <0.00%> (ø)
les/state_accessor.go 0.00% <0.00%> (ø)
miner/fake_miner.go 89.61% <ø> (ø)
miner/miner.go 79.22% <ø> (ø)
core/vm/evm.go 15.46% <20.00%> (ø)
eth/tracers/api.go 22.24% <25.00%> (ø)
core/vm/interpreter.go 23.28% <33.33%> (-26.21%) ⬇️
core/state_processor.go 93.54% <60.00%> (-3.12%) ⬇️
... and 9 more

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xsharma 0xsharma changed the title [WIP] core/vm, miner : Make commitInterrupt OPCODE level core/vm, miner : Make commitInterrupt OPCODE level Apr 12, 2023
@0xsharma 0xsharma marked this pull request as ready for review April 12, 2023 12:48
@0xsharma 0xsharma requested review from JekaMas and a team April 12, 2023 20:44
core/vm/interpreter.go Outdated Show resolved Hide resolved
@0xsharma 0xsharma merged commit acff69a into develop May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants