Optimized the dependency metadata structure #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cffls
reviewed
Apr 3, 2023
core/parallel_state_processor.go
Outdated
|
|
||
| if len(header.TxDependency) > 0 { |
There was a problem hiding this comment.
Should we check if len(header.TxDependency) == len(tasks)? If lengths mismatch, we shouldn't use any dependency data.
There was a problem hiding this comment.
Nice idea. Thanks!
miner/worker.go
Outdated
Comment on lines
1152
to
1154
| if ok1 || ok2 { | ||
| // 0 -> delay is not allowed | ||
| tempDeps[i] = append(tempDeps[i], 0) |
There was a problem hiding this comment.
I think we should still keep this check. When delay is not allowed, we simply set dependency to empty, so validators will directly run serial execution.
There was a problem hiding this comment.
Yes, that will be nice.
cffls
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I removed the first 2 elements in the TxDependency structure: the Transaction index and flag informing about delaying the fee transfer.