miner/worker :: add : start commit work only after connecting to peers #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manav2401
approved these changes
Aug 30, 2023
VAIBHAVJINDAL3012
approved these changes
Aug 30, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we wait for a validator node to connect to atleast 1 peer before starting to produce blocks. This helps in stopping the validator to creating its own fork which might later result in the entire networking getting reorged to that fork. This PR tries to improve the stability of the network.
This is only implemented to work on
mainnetandmumbai. It will not work on devnets/testnets.