Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP - to be tested] mardizzone/bump-versions #991

Closed
wants to merge 3 commits into from

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Sep 7, 2023

Description

Bump versions of our forks of tendermint and cosmos-sdk to latest commits on default branches.
Also, bump go version to latest stable release.
As an advice, we should always bump those versions to be on top of default branches.
Furthermore, as bor is used as a dependency in heimdall, we should always keep them aligned every time a new bor version is released.

Checklist before merging:

  • Bump deps, merge default branch and create a release for tendermint and update this bor go.mod file
  • Bump deps, merge default branch and merge this cosmos-sdk PR, then create a release for cosmos-sdk and update this bor go.mod
  • Replace bor v1.0.0-beta with bor v1.0.6

These changes have been tested on devnets and CIs, but merge is postponed until

  1. Milestones feature is fully tested on Mumbai, and bor v1.0.6 and heimdall v1.0.2 versions are released
  2. We finalise the ongoing tests on Mumbai and Mainnet nodes with comsos-sdk and tendermint upgrades. Mumbai worked as expected. Waiting for Mainnet HF to kick in.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Tests on Mumbai ongoing...

@marcello33 marcello33 closed this Oct 4, 2023
@marcello33 marcello33 reopened this Oct 4, 2023
@marcello33
Copy link
Contributor Author

Closed as included here

@marcello33 marcello33 closed this Oct 16, 2023
@marcello33 marcello33 deleted the mardizzone/bump-versions branch November 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants