This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 506
POL updates, migration to Foundry/Hardhat #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix depositBulk using mapToken
Plasma bridge update
Migration from Truffle to Hardhat/Foundry
dev1644
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge includes 3 different major changes:
plasma-bridge-update
branch (reviewed and audited)Migration details
We used the new Foundry template repo as a starting point, but incorporated Hardhat to easily re-use the old tests.
All test were then migrated to be used with new JS version and Hardhat framework
No Smart Contract was edited during this migration!
Goals:
type: module
As the old tests relied heavily on
import
statements, we decided to make the whole project"type": "module"
.This results in the necessary renaming of some config files like
hardhat.config.cjs
orsolcover.cjs
using the cjs extension.Config
To maintain a single source of truth for our config, we import
foundry.toml
intohardhat.config.cjs
to define solidity version and optimiser runs.