Handle account sequence correctly in bridge #1170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The job of the
broadcaster
component is, as the name suggests, to broadcast txs to tendermint. The ante handler is executed duringcheckTx
(invoked by tendermint) and enforces some sanity checks on the tx sent (ensuring enough balance, correct signature, etc.) and at successful verification, increments the account sequence (akin to nonce).If any of the checks were to fail, the appropriate error code is baked in
sdk.TxResponse
.Currently, the
broadcaster
doesn't account for a failed sanity clause (and only checks for errors that pop up during the broadcast itself). This results in an incorrect increment of the bridge's "cached" account sequence and hence causes mismatch with the DB. This PR aims to fix this.Changes
Checklist
Testing