Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version command runs on all binaries #779

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Mar 1, 2022

This PR ensures that the version command can be used with all binaries (heimdalld, heimdallcli and bridge).

One issue was that a config file was required in order to run any command (which is now only required when not running the version command).

Another issue was that the BUILD_FLAGS weren't passed to the go build command.

@vcastellm vcastellm requested a review from ssandeep March 2, 2022 11:14
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #779 (5ca1c1b) into master (6569fcd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   72.89%   72.89%           
=======================================
  Files          49       49           
  Lines        3508     3508           
=======================================
  Hits         2557     2557           
  Misses        723      723           
  Partials      228      228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6569fcd...5ca1c1b. Read the comment docs.

@vcastellm vcastellm merged commit 52dfc0f into maticnetwork:master Mar 16, 2022
@ngotchac ngotchac deleted the ngotchac/fix-version branch March 16, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants