Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkpoint ID in REST APIs Result #806

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2022

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #806 (b71652f) into master (8889642) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   72.73%   72.73%           
=======================================
  Files          49       49           
  Lines        3517     3517           
=======================================
  Hits         2558     2558           
  Misses        730      730           
  Partials      229      229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8889642...b71652f. Read the comment docs.

@ghost ghost requested review from 0xsharma, manav2401, ssandeep and temaniarpit27 March 29, 2022 12:18
@ghost ghost requested a review from temaniarpit27 April 3, 2022 19:35
Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@temaniarpit27
Copy link
Contributor

@Vaibhavjindal29 how was testing done for this?

@temaniarpit27 temaniarpit27 marked this pull request as ready for review April 27, 2022 09:35
@temaniarpit27 temaniarpit27 merged commit b3ca506 into master Apr 27, 2022
@temaniarpit27 temaniarpit27 deleted the vaibhav/POS-279 branch April 27, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants