Add linter to CI pipeline #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
begmaroman
commented
Jun 22, 2022
•
begmaroman
commented
- Added linter to CI pipeline
- Fixed all linter nits in the code
Codecov Report
@@ Coverage Diff @@
## develop #844 +/- ##
===========================================
+ Coverage 73.82% 75.61% +1.79%
===========================================
Files 49 49
Lines 5348 5282 -66
===========================================
+ Hits 3948 3994 +46
+ Misses 1170 1055 -115
- Partials 230 233 +3
Continue to review full report at Codecov.
|
…pipeline # Conflicts: # .github/workflows/ci.yml
|
@begmaroman Could you hold this PR until we merge this one #842? 🙏 There will be many new changes coming from v0.3.0. It might be easier to lint everything after we merge everything from v0.3.0. |
…pipeline # Conflicts: # bridge/setu/processor/clerk_test.go
temaniarpit27
approved these changes
Jun 27, 2022
JekaMas
approved these changes
Jun 28, 2022
|
Looks like integration tests are failing. Could you check the logs and see why it failed? |
|
@cffls fixed |
cffls
pushed a commit
to cffls/heimdall
that referenced
this pull request
Aug 3, 2022
cffls
pushed a commit
that referenced
this pull request
Aug 4, 2022
manav2401
added a commit
that referenced
this pull request
Sep 22, 2022
* task delay change * fix * add checks in clu * remove cli checks * add testcase * Set default max number of open files for heimdall service * Add 'heimdall' user during package installation * Fixed helper.UnpackLog function call in the self-healing process (#853) * Add linter to CI pipeline (#844) * Remove dependency on mainnet.toml and mumbai.toml In new CLI, a single binary should work for both mainnet and testnet. This change will remove the dependency on mainnet.toml and mumbai.toml in build time so we won't need to build two different binaries for each network. * fix: remove duplicate import Co-authored-by: Arpit Temani <temaniarpit27@gmail.com> Co-authored-by: Jerry <jerrycgh@gmail.com> Co-authored-by: Roman Behma <13855864+begmaroman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.