Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pydantic 1.10.12 #32

Closed
encodedLife opened this issue Nov 2, 2023 · 3 comments · Fixed by #33
Closed

pydantic 1.10.12 #32

encodedLife opened this issue Nov 2, 2023 · 3 comments · Fixed by #33
Assignees
@matin

Comments

@encodedLife
Copy link

First of all I wanted to express my appreciation for your work – your library is fantastic and has been incredibly useful.

I'm currently developing a custom integration for HomeAssistant, which relies on pydantic version 1.10.12 as part of its core dependencies. Would it be feasible for you to adjust the minimum required version of your library to be compatible with pydantic 1.10.12?
@matin matin self-assigned this Nov 2, 2023
matin added a commit that referenced this issue Nov 2, 2023
@matin
adjust dependency versions. closes #32
a68870f
@matin matin mentioned this issue Nov 2, 2023
Merged
@matin
Copy link
Owner

matin commented Nov 2, 2023

Thank you for the kind words! I'm happy that you've found is so useful.

It's certainly feasible. I'll make the change now.

@matin matin closed this as completed in #33 Nov 2, 2023
matin added a commit that referenced this issue Nov 2, 2023
@matin
Adjust dependency versions (#33)
fad9855 
* adjust dependency versions. closes #32

* add 3.12 to ci

* add 3.12 classifier

* bump version
@matin
Copy link
Owner

matin commented Nov 2, 2023 •
edited
Loading

@encodedLife v0.4.40 now supports Pydantic 1.10.12. Thanks for reporting the issue!

@encodedLife
Copy link
Author

Thank you for the prompt reply and quick implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matin matin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust dependency versions matin/garth
2 participants
@matin @encodedLife