Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pydantic 1 #15

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Support Pydantic 1 #15

merged 1 commit into from
Sep 30, 2023

Conversation

matin
Copy link
Owner

@matin matin commented Sep 30, 2023

Support backwards compatibility with Pydantic 1. Tested on Pydantic 1.10.13.

Closes #14 and cyberjunky/python-garminconnect#162

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2a0dae9) 100.00% compared to head (15b78d2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1013      1013           
=========================================
  Hits          1013      1013           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
garth/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matin matin merged commit 2d1b211 into main Sep 30, 2023
20 checks passed
@matin matin deleted the pydantic1 branch September 30, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate support of Pydantic 1.8
1 participant